Jump to content

Review trailing spaces in messages.properties

Review trailing spaces in messages.properties

After the import, nikerabbit noticed some messages have trailing spaces that should be removed:

http://translatewiki.net/static/mifos-trailing-whitespace-list.txt

Jasmine also said some of them are there intentionally. Need to review each message flagged in the list above and trim as necessary.

Stanley18:57, 15 October 2010

Just for my knowledge. What side effects will we see in the translations if we have a trailing whitespace. I know I have a single trailing whitespace in some messages because they get appended. And maybe I need to amend that so that if two messages are appended, they should be put in one single message instead of two. But that's not something I want to do on the fly, so it would be good to understand the problem a bit more - thanks.

Jasmine19:22, 15 October 2010

Trailing spaces will not appear in translated properties files so we need to be mindful of whether those trailing spaces are required or not.

Jasmine19:31, 15 October 2010
 

There are still such messages. Here is a new list:

note
toquicklyfindAClientCenterGroupaccountyoucan
manadatoryHiddenFields.familyDetails
manadatoryHiddenFields.spouse/fathermiddlename
manadatoryHiddenFields.sourceOfFund
manageRoles.offices
offices.viewoffices.clickonanofficebelowtoviewdetailsandmakechangesor
organizationPreferences.viewholidays.belowIsTheListOfOrganizationWideHolidaysClickHereTo
datadisplayandrules.editadditionalfields.savings
dataDisplayAndRules.defineLookupOptions.indian
dataDisplayAndRules.defineLookupOptions.collegeDegree
organizationPreferences.viewChecklists.Clickonachecklistbelowtoviewdetailsandmakechangesor
datadisplayandrules.defineLabels.graceonallrepayments (is the \ needed in this message?)
login.UserName
manageLoanProducts.viewLoanProducts.clickonaLoanproductbelowtoviewdetailsandmakechangesor
systemUsers.preview.edituser
systemUsers.preview.permissions
editReportCategory.informationmessage

Some of them are clearly lego or patchwork messages.

Nike13:10, 28 October 2010

I've removed all trailing spaces from messages.properties per request. Fixed by http://mifosforge.jira.com/browse/MIFOS-4066.

Stanley03:40, 1 November 2010

Thanks. Do mind though that trailing spaces are usually a sign that patchwork messages are in play, and that this may have caused spacing/word separation issues if done bluntly.

Siebrand07:13, 1 November 2010

I've gone through each message identified above to ensure that it is safe to remove trailing spaces.

Stanley15:45, 1 November 2010