Jump to content

Typos etc.

Fragment of a discussion from User talk:Purodha

I managed to submit a patch to core.

The gerrit web site says it was erroneous - that is at least how I interpret the -1 in the Code-Review column - and there were 2 comments on it in this context. How or where can I find these comments, and how to find out what is wrong?

Purodha Blissenbach (talk)09:48, 21 March 2015

You have to click on "Side-by-Side" to open the diff view for the corresponding file, for example: https://gerrit.wikimedia.org/r/#/c/198300/1/includes/skins/SkinFallbackTemplate.php There you can see the comment (in this case on the right side, but it is also possible to add it to the left). You can also reply there. To publish a added comment you have to add a (empty) comment to the whole patch set.

Der Umherirrende (talk)19:03, 25 March 2015