Code review
Fragment of a discussion from User talk:Purodha
- Reporting in phabricator when I see that a patch would take too long or was too complicated is exactly what I would like to do.
But remember: phabricator is dead for me. - PLURAL and GENDER support were among the easiest things I did for long. But they require imho that I test them (unlike pure message text amendments) and I do not have access to a working MediaWiki test installation. The latest failure to get one was that tools lab does not have composer, if I recall that right, and I cannot request that changed, see above.
Thus I unset my name from all such tasks assigned to me at the moment.
- I work under the assumption that WMF ops will eventually fix Phabricator for you... You could try emailing ops-requests@rt.wikimedia.org to ask help, IIRC this bridge still works.
- In many cases, GENDER and PLURAL don't require testing: sometimes they don't even need code changes, because the developer just forgot to use the magic word in the English text. Anyway, that's fine; please assign the PLURAL and GENDER stuff back to me when you can't handle them, so that I remember to do what needed.
- Just sent an e-mail.
- Yes, you are right. It is only frustrating when I find that I have a fix but cannot test and submit it. Maybe I should learn to live with the risk ;-)
- Hm, not sure it worked, we'll see.
- If you think more testing is needed, you can just -1 yourself and say so. Especially for WMF-developed extensions, filing a patch is just a nicer (and often easier) bug report coming with a clear solution proposal. It's still their responsibility to fix; people with +2 rights can and should test where needed.